Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: local versions are available not downloaded #1528

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: local versions are available not downloaded #1528

merged 1 commit into from
Jan 15, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 13, 2024 •
edited
Loading

It doesn't really make sense paradigmatically to call local versions "downloaded" if they're available. Change to "Available".

Before:

Screenshot 2024-01-13 at 10 12 53 AM

After:

Screenshot 2024-01-13 at 10 13 41 AM

@codebytere codebytere requested a review from a team as a code owner January 13, 2024 09:15
@codebytere codebytere changed the title fix: Local versions are available not downloaded fix: local versions are available not downloaded Jan 13, 2024
@coveralls
Copy link

Coverage Status

coverage: 87.108% (+0.005%) from 87.103%
when pulling 22bba15 on local-downloaded-more-human
into fe192ae on main.

@codebytere codebytere merged commit 5cfd342 into main Jan 15, 2024
10 checks passed
@codebytere codebytere deleted the local-downloaded-more-human branch January 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao Awaiting requested review from erickzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @coveralls @dsanders11