Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update show me examples #1527

Merged
merged 1 commit into from
Jan 10, 2024
Merged

chore: update show me examples #1527

merged 1 commit into from
Jan 10, 2024

Conversation

dsanders11
Copy link
Member

Closes #1361

Modernizes these example fiddles (dropping options which have long been the default) and fixes ones which were using defunct callback syntax.

@dsanders11 dsanders11 requested review from codebytere and a team as code owners January 9, 2024 20:35
@coveralls
Copy link

Coverage Status

coverage: 87.103%. remained the same
when pulling 1edf244 on update-show-me
into 54d9012 on main.

BlackHole1
BlackHole1 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit fe192ae into main Jan 10, 2024
10 checks passed
@codebytere codebytere deleted the update-show-me branch January 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@ckerr ckerr ckerr approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Me Examples Still Use Callback APIs
5 participants
@dsanders11 @coveralls @ckerr @BlackHole1 @codebytere