feat: add support for JSON files in editors #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Running this locally, I get package-lock.json when I start up with 27.0.0 selected. Probably because we pull the content from https://github.com/electron/electron-quick-start/tree/27-x-y and that has a package-lock.json.
|
Minor, but while you can't add a new file called |
codebytere
force-pushed
the
support-json-files
branch
2 times, most recently
from
2cb6c96 to
ad5966a
Compare
dsanders11
approved these changes
Nov 10, 2023
codebytere
force-pushed
the
support-json-files
branch
from
ad5966a to
5127126
Compare
dsanders11
reviewed
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for JSON files. These can be used in Fiddle for data storage amongst other things - the impetus for this specifically is the ability to add
manifest.jsonfiles for Chrome extensions.