Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use GitHub actions for Coveralls #1473

Merged
merged 2 commits into from
Sep 28, 2023
Merged

ci: use GitHub actions for Coveralls #1473

merged 2 commits into from
Sep 28, 2023

Conversation

dsanders11
Copy link
Member

If you use Coveralls from anything other than GitHub actions you need to provide a repo token, which doesn't work with forks because we don't want to expose secrets to them. It works on GitHub actions though, so bring it back there.

@coveralls
Copy link

Coverage Status

coverage: 87.059%. remained the same when pulling b8ff165 on dsanders11:coveralls-gha into b6fb28d on electron:main.

@dsanders11 dsanders11 marked this pull request as ready for review September 28, 2023 19:24
@dsanders11 dsanders11 requested review from codebytere and a team as code owners September 28, 2023 19:24
@dsanders11 dsanders11 merged commit 1e40d19 into electron:main Sep 28, 2023
4 checks passed
@dsanders11 dsanders11 deleted the coveralls-gha branch September 28, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsanders11 @coveralls @VerteDinde