Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use process.env when running fiddle #1472

Merged
merged 2 commits into from
Sep 30, 2023
Merged

fix: use process.env when running fiddle #1472

merged 2 commits into from
Sep 30, 2023

Conversation

dsanders11
Copy link
Member

Fixes #1470.

@dsanders11 dsanders11 requested review from codebytere and a team as code owners September 28, 2023 12:57
@dsanders11 dsanders11 marked this pull request as draft September 28, 2023 15:25
@coveralls
Copy link

coveralls commented Sep 28, 2023 •
edited
Loading

Coverage Status

coverage: 87.366% (+0.3%) from 87.059% when pulling 642f522 on dsanders11:fix-electron-env into 1e40d19 on electron:main.

@dsanders11 dsanders11 marked this pull request as ready for review September 29, 2023 00:01
@dsanders11 dsanders11 marked this pull request as draft September 29, 2023 00:07
@dsanders11 dsanders11 marked this pull request as ready for review September 29, 2023 15:03
@dsanders11
Copy link
Member Author

Updated this to better match the original behavior and added test coverage.

erikian
erikian approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@erikian erikian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM!

@dsanders11 dsanders11 merged commit 68d9c98 into electron:main Sep 30, 2023
4 checks passed
@sentry-io
Copy link

sentry-io bot commented Oct 1, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: write EPIPE startFiddle(src/main/fiddle-core) View Issue

Did you find this useful? React with a 👍 or 👎

@dsanders11 dsanders11 deleted the fix-electron-env branch October 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikian erikian erikian approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fiddle fails to launch Electron process on Linux
3 participants
@dsanders11 @coveralls @erikian