Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't unset Electron typings when setting Node typings #1221

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix: don't unset Electron typings when setting Node typings #1221

merged 1 commit into from
Jan 5, 2023

Conversation

dsanders11
Copy link
Member

This was throwing away the Electron typings when adding the Node ones. The previous typings are already disposed (via clear()) in setVersion, so these calls to dispose were redundant anyway.

Tests may flake until #1220 is merged.

@dsanders11 dsanders11 requested review from codebytere and a team December 8, 2022 00:37
@coveralls
Copy link

coveralls commented Dec 8, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 91.423% when pulling cf20e4a on dsanders11:fix-electron-intellisense into bfb0dfe on electron:main.

@codebytere codebytere merged commit db4e539 into electron:main Jan 5, 2023
@dsanders11 dsanders11 deleted the fix-electron-intellisense branch January 5, 2023 17:43
@dsanders11 dsanders11 mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsanders11 @coveralls @codebytere @BlackHole1