Skip to content

Conversation

byquanton
Copy link

@byquanton byquanton commented Sep 2, 2025

Description of Change

The Pipewire Capturer implementation in Electron has some Caveats, but those are only documented in the codebase.

// PipeWire returns a single source, so index is not relevant.

// Some capturers like PipeWire support a single capturer for both screens
// and windows. Use it if possible, treating both as window capture

Checklist

Notes: none

Copy link

welcome bot commented Sep 2, 2025

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@byquanton byquanton force-pushed the docs/pipewire-caveats branch from 878c92e to 228b944 Compare September 2, 2025 16:22
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant