feat: expose safestorage backend information on linux by deepak1556 · Pull Request #38873 · electron/electron

deepak1556 · 2023-06-21T16:23:59Z

Description of Change

It is currently not possible to determine why encryption is not available on Linux at runtime (i-e) which backend was attempted to be initialized. It is possible to get these information via --vmodule="*/components/os_crypt/*=1" but having the information at runtime would be helpful for applications to surface better error to users. The PR introduces two new API

safeStorage.getSelectedStorageBackend() to retrieve the preferred storage backend information
safeStorage.setUsePlainTextEncryption(usePlainText) to allow using the weaker plain text password for the encryption key, can be used as default when no storage backends are available on Linux.

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation, tutorials, templates and examples are changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Add safeStorage.setUsePlainTextEncryption and safeStorage.getSelectedStorageBackend api

jkleinsc

API LGTM

zcbenz

API LGTM

jkleinsc · 2023-07-05T20:02:40Z

@deepak1556 the Windows test failures seem to be caused by this PR.

deepak1556 · 2023-07-11T04:12:27Z

Hmm that should be unlikely since the changes are guarded for linux. Let me rebase on latest main

codebytere · 2023-07-11T08:29:07Z

@deepak1556 looks like this is affected by https://chromium-review.googlesource.com/c/chromium/src/+/4609704

Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704

codebytere

API LGTM

release-clerk · 2023-07-13T09:14:37Z

Release Notes Persisted

Add safeStorage.setUsePlainTextEncryption and safeStorage.getSelectedStorageBackend api

trop · 2023-07-13T09:14:51Z

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

trop · 2023-07-13T09:14:54Z

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

miniak · 2023-07-14T14:41:36Z

/trop run backport-to 26-x-y

trop · 2023-07-14T14:41:39Z

The backport process for this PR has been manually initiated - sending your PR to 26-x-y!

trop · 2023-07-14T14:42:08Z

I have automatically backported this PR to "26-x-y", please check out #39107

codebytere · 2023-07-19T13:07:31Z

/trop run backport-to 26-x-y

trop · 2023-07-19T13:07:33Z

The backport process for this PR has been manually initiated - sending your PR to 26-x-y!

trop · 2023-07-19T13:07:57Z

I have automatically backported this PR to "26-x-y", please check out #39155

trop · 2023-08-02T02:18:41Z

@deepak1556 has manually backported this PR to "25-x-y", please check out #39325

* feat: expose safestorage backend information on linux * Remove gnome-keyring Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704

electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 21, 2023

deepak1556 added api-review/requested 🗳 semver/minor backwards-compatible functionality target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Jun 21, 2023

deepak1556 mentioned this pull request Jun 23, 2023

chore: bump electron@22.3.14 microsoft/vscode#185983

Merged

jkleinsc reviewed Jun 26, 2023

View reviewed changes

zcbenz approved these changes Jun 27, 2023

View reviewed changes

electron-cation Bot added api-review/approved ✅ and removed new-pr 🌱 PR opened recently api-review/requested 🗳 labels Jun 28, 2023

feat: expose safestorage backend information on linux

6e1e0ac

deepak1556 force-pushed the robo/expose_oscrypt_backend branch from cfad7bb to 6e1e0ac Compare July 11, 2023 05:05

Remove gnome-keyring

47b7824

Refs https://chromium-review.googlesource.com/c/chromium/src/+/4609704

VerteDinde approved these changes Jul 11, 2023

View reviewed changes

codebytere requested a review from jkleinsc July 11, 2023 21:28

codebytere approved these changes Jul 13, 2023

View reviewed changes

codebytere merged commit 34e7c36 into main Jul 13, 2023

codebytere deleted the robo/expose_oscrypt_backend branch July 13, 2023 09:14

trop Bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Jul 13, 2023

trop Bot added needs-manual-bp/25-x-y needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Jul 13, 2023

trop Bot mentioned this pull request Jul 14, 2023

feat: expose safestorage backend information on linux #39107

Merged

trop Bot added in-flight/26-x-y merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/26-x-y labels Jul 14, 2023

codebytere removed the merged/26-x-y PR was merged to the "26-x-y" branch. label Jul 19, 2023

trop Bot mentioned this pull request Jul 19, 2023

feat: expose safestorage backend information on linux #39155

Merged

trop Bot added in-flight/26-x-y merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/26-x-y labels Jul 19, 2023

codebytere removed needs-manual-bp/24-x-y needs-manual-bp/25-x-y labels Jul 31, 2023

deepak1556 mentioned this pull request Aug 2, 2023

feat: expose safestorage backend information on linux #39325

Merged

trop Bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/25-x-y labels Aug 2, 2023

ghost mentioned this pull request Sep 26, 2023

[pull] main from electron:main Blaquez-home/electron#3

Open

ckerr mentioned this pull request Jul 24, 2024

refactor: move safe_storage functions into anonymous namespace #43032

Merged

3 tasks

This was referenced Jul 16, 2026

Add ACP agent threads and Git diff workflows zixiao-labs/logos#9

Merged

F1 bootstrap: strip local server + LLM calls, wire control plane (#TI-385) asymblinc/asymbl-ti-desktop#1

Open

MarshallOfSound mentioned this pull request Aug 11, 2026

[Feature Request]: set up mockDbus for linux keyring tests #30424

Closed

3 tasks

Uh oh!

Conversation

deepak1556 commented Jun 21, 2023

Description of Change

Checklist

Release Notes

Uh oh!

jkleinsc left a comment

Choose a reason for hiding this comment

Uh oh!

zcbenz left a comment

Choose a reason for hiding this comment

Uh oh!

jkleinsc commented Jul 5, 2023

Uh oh!

deepak1556 commented Jul 11, 2023

Uh oh!

codebytere commented Jul 11, 2023

Uh oh!

codebytere left a comment

Choose a reason for hiding this comment

Uh oh!

release-clerk Bot commented Jul 13, 2023

Uh oh!

trop Bot commented Jul 13, 2023

Uh oh!

trop Bot commented Jul 13, 2023

Uh oh!

miniak commented Jul 14, 2023

Uh oh!

trop Bot commented Jul 14, 2023

Uh oh!

trop Bot commented Jul 14, 2023

Uh oh!

codebytere commented Jul 19, 2023

Uh oh!

trop Bot commented Jul 19, 2023

Uh oh!

trop Bot commented Jul 19, 2023

Uh oh!

trop Bot commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants