Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #10697 #10873

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix for issue #10697 #10873

merged 1 commit into from
Oct 23, 2017

Conversation

ahmedmohamedali
Copy link
Contributor

This PR is to fix the crash described in the issue #10697.
The root cause is zoom_controller_ is not initialized for dev tools.

@ahmedmohamedali ahmedmohamedali requested a review from a team October 21, 2017 21:05
@ahmedmohamedali ahmedmohamedali changed the title Electron crashes if user clicks Dev Tools & Zoom options #10697 Fix for issue #10697 Oct 21, 2017
deepak1556
deepak1556 approved these changes Oct 22, 2017
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkleinsc jkleinsc merged commit 67f0eb7 into electron:master Oct 23, 2017
@ahmedmohamedali ahmedmohamedali deleted the fix_issue_10697 branch October 23, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedmohamedali @deepak1556 @jkleinsc