Convert to use the electron-installer-common ElectronInstaller class #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
changed the title
fcastilloec
previously requested changes
Jan 23, 2019
There was a problem hiding this comment.
This looks great except for minor things. The changes are more towards the tests. For example, the test 'with an app with a scoped name' is not needed anymore since that was moved to -common.
I have mixed feelings about 'move LICENSE to Debian-specific location' since that was also moved to -common.
If you're planning on fixing the tests in a different PR, let me know and I'll change this to "approve". Also, should we add codecov here too?
|
I'll delete the tests here.
In a different PR, I'd say. |
|
I fixed the too-long-line & removed some duplicate tests. |
fcastilloec
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation using electron-userland/electron-installer-common#13. It ends up being more lines of code because there are some other refactors in there, namely adding
getMaintainer(),normalizeDescription(), andnormalizeProductDescription().TODO
electron-installer-commonversion in this PR