Skip to content

fix: update the dmgbuild hex regex to be case insensitive #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmaietta merged 3 commits into from
Jan 7, 2026
Merged

fix: update the dmgbuild hex regex to be case insensitive #9487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b940a4d
Make hex color regex case insensitive
Kilian Jan 7, 2026
7ce25e9
Make hex color regex case insensitive
Kilian Jan 7, 2026
10ff035
Create unlucky-rings-exist.md
mmaietta Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-rings-exist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"dmg-builder": patch
---

fix: update the `dmgbuild` hex regex for `backgroundColor` to be case insensitive
2 changes: 1 addition & 1 deletion packages/dmg-builder/vendor/dmgbuild/colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def to_rgb(self):

_ws_re = re.compile(r"\s+")
_token_re = re.compile(r"[A-Za-z_][A-Za-z0-9_]*")
_hex_re = re.compile(r"#([0-9a-f]{3}(?:[0-9a-f]{3})?)$")
_hex_re = re.compile(r"#([0-9a-f]{3}(?:[0-9a-f]{3})?)$", re.IGNORECASE)
_number_re = re.compile(r"[0-9]*(\.[0-9]*)")


Expand Down
2 changes: 1 addition & 1 deletion packages/dmg-builder/vendor/dmgbuild/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
badge = None


_hexcolor_re = re.compile(r"#[0-9a-f]{3}(?:[0-9a-f]{3})?")
_hexcolor_re = re.compile(r"#[0-9a-f]{3}(?:[0-9a-f]{3})?", re.IGNORECASE)

# The first element in the platform.mac_ver() tuple is a string containing the
# macOS version (e.g., '10.15.6'). Parse into an integer tuple.
Expand Down