Skip to content

fix: deleting default macOS appPlist keys using extendInfo #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmaietta merged 3 commits into from
Jan 6, 2026
Merged

fix: deleting default macOS appPlist keys using extendInfo #9481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d326436
fix: deleting default macOS appPlist keys using extendInfo
Lemonexe Jan 4, 2026
ac0c5c2
Create fifty-laws-jog.md
mmaietta Jan 4, 2026
703beee
Merge branch 'master' into fix/undefined-extendedInfo-values
mmaietta Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-laws-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: delete default macOS appPlist keys using extendInfo when set Nullish
3 changes: 3 additions & 0 deletions packages/app-builder-lib/src/macPackager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ export class MacPackager extends PlatformPackager<MacConfiguration> {
if (extendInfo != null) {
Object.assign(appPlist, extendInfo)
}
for (const [k, v] of Object.entries(appPlist)) {
if (v === null || v === undefined) delete appPlist[k]
}
}

protected async signApp(packContext: AfterPackContext, isAsar: boolean): Promise<boolean> {
Expand Down
2 changes: 2 additions & 0 deletions test/src/mac/macPackagerTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ test.ifMac("one-package", ({ expect }) =>
LSItemContentTypes: ["public.folder"],
},
],
// test unsetting a default electron plist value
NSMicrophoneUsageDescription: undefined,
},
minimumSystemVersion: "10.12.0",
fileAssociations: [
Expand Down