fix: stack overflow in electron-builder due to cyclic dependencies in _getNodeModules#9193
Closed
DinoscapeProgramming wants to merge 1 commit intoelectron-userland:masterfrom
Closed
fix: stack overflow in electron-builder due to cyclic dependencies in _getNodeModules#9193DinoscapeProgramming wants to merge 1 commit intoelectron-userland:masterfrom
DinoscapeProgramming wants to merge 1 commit intoelectron-userland:masterfrom
Conversation
…cies Adds cycle detection using a Set<string> to avoid infinite recursion when traversing hoisted dependency graphs. Fixes "Maximum call stack size exceeded" error during electron-builder packaging.
DinoscapeProgramming
changed the title
Author
|
Sorry, didn't see #8864. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a "Maximum call stack size exceeded" error caused by infinite recursion in the
_getNodeModulesmethod withinNodeModulesCollector.Root Cause
The function did not account for cyclic dependencies in the hoisted dependency graph, causing unbounded recursion and stack overflows during the build process.
Fix
Set<string>to track visited dependencies.name@version.Impact
electron-builderpackaging in large or monorepo projects.Originally reported in #8857.