chore(plist): replace the plist functionality in app-builder-bin with plist

packages/app-builder-lib/package.json

@@ -77,7 +77,8 @@
     "semver": "^7.3.8",
     "tar": "^6.1.12",
     "temp-file": "^3.4.0",
-    "tiny-async-pool": "1.3.0"
+    "tiny-async-pool": "1.3.0",
+    "simple-plist": "1.3.1"
   },
   "///": "babel in devDependencies for proton tests",
   "devDependencies": {

packages/app-builder-lib/src/electron/electronMac.ts

@@ -5,7 +5,8 @@ import { filterCFBundleIdentifier } from "../appInfo"
 import { AsarIntegrity } from "../asar/integrity"
 import { MacPackager } from "../macPackager"
 import { normalizeExt } from "../platformPackager"
-import { executeAppBuilderAndWriteJson, executeAppBuilderAsJson } from "../util/appBuilder"
+import SimplePlist from "simple-plist"
+import { executeAppBuilderAsJson } from "../util/appBuilder"
 import { createBrandingOpts } from "./ElectronFramework"
 
 function doRename(basePath: string, oldName: string, newName: string) {
@@ -229,31 +230,34 @@ export async function createMacApp(packager: MacPackager, appOutDir: string, asa
     appPlist.ElectronAsarIntegrity = asarIntegrity
   }
 
-  const plistDataToWrite: any = {
-    [appPlistFilename]: appPlist,
-    [helperPlistFilename]: helperPlist,
-  }
   if (helperEHPlist != null) {
-    plistDataToWrite[helperEHPlistFilename] = helperEHPlist
+    SimplePlist.writeFileSync(helperEHPlistFilename, helperEHPlist)
   }
+
   if (helperNPPlist != null) {
-    plistDataToWrite[helperNPPlistFilename] = helperNPPlist
+    SimplePlist.writeFileSync(helperNPPlistFilename, helperNPPlist)
   }
+
   if (helperRendererPlist != null) {
-    plistDataToWrite[helperRendererPlistFilename] = helperRendererPlist
+    SimplePlist.writeFileSync(helperRendererPlistFilename, helperRendererPlist)
   }
+
   if (helperPluginPlist != null) {
-    plistDataToWrite[helperPluginPlistFilename] = helperPluginPlist
+    SimplePlist.writeFileSync(helperPluginPlistFilename, helperPluginPlist)
   }
+
   if (helperGPUPlist != null) {
-    plistDataToWrite[helperGPUPlistFilename] = helperGPUPlist
+    SimplePlist.writeFileSync(helperGPUPlistFilename, helperGPUPlist)
   }
+
   if (helperLoginPlist != null) {
-    plistDataToWrite[helperLoginPlistFilename] = helperLoginPlist
+    SimplePlist.writeFileSync(helperLoginPlistFilename, helperLoginPlist)
   }
 
+  SimplePlist.writeFileSync(appPlistFilename, appPlist)
+  SimplePlist.writeFileSync(helperPlistFilename, helperPlist)
+
   await Promise.all([
-    executeAppBuilderAndWriteJson(["encode-plist"], plistDataToWrite),
     doRename(path.join(contentsPath, "MacOS"), electronBranding.productName, appPlist.CFBundleExecutable),
     unlinkIfExists(path.join(appOutDir, "LICENSE")),
     unlinkIfExists(path.join(appOutDir, "LICENSES.chromium.html")),

packages/app-builder-lib/src/frameworks/LibUiFramework.ts

@@ -7,7 +7,7 @@ import { Platform } from "../core"
 import { Framework, PrepareApplicationStageDirectoryOptions } from "../Framework"
 import { LinuxPackager } from "../linuxPackager"
 import { MacPackager } from "../macPackager"
-import { executeAppBuilderAndWriteJson } from "../util/appBuilder"
+import SimplePlist from "simple-plist"
 
 export class LibUiFramework implements Framework {
   readonly name: string = "libui"
@@ -71,16 +71,14 @@ export class LibUiFramework implements Framework {
       NSHighResolutionCapable: true,
     }
     await packager.applyCommonInfo(appPlist, appContentsDir)
-    await Promise.all([
-      executeAppBuilderAndWriteJson(["encode-plist"], { [path.join(appContentsDir, "Info.plist")]: appPlist }),
-      writeExecutableMain(
-        path.join(appContentsDir, "MacOS", appPlist.CFBundleExecutable),
-        `#!/bin/sh
+    SimplePlist.writeFileSync(path.join(appContentsDir, "Info.plist"), appPlist)
+    await writeExecutableMain(
+      path.join(appContentsDir, "MacOS", appPlist.CFBundleExecutable),
+      `#!/bin/sh
   DIR=$(dirname "$0")
   "$DIR/node" "$DIR/../Resources/app/${options.packager.info.metadata.main || "index.js"}"
   `
-      ),
-    ])
+    )
   }
 
   private async prepareLinuxApplicationStageDirectory(options: PrepareApplicationStageDirectoryOptions) {

packages/app-builder-lib/src/targets/pkg.ts

@@ -8,7 +8,8 @@ import { findIdentity, Identity } from "../codeSign/macCodeSign"
 import { Target } from "../core"
 import { MacPackager } from "../macPackager"
 import { PkgOptions } from "../options/pkgOptions"
-import { executeAppBuilderAndWriteJson, executeAppBuilderAsJson } from "../util/appBuilder"
+import SimplePlist from "simple-plist"
+import { executeAppBuilderAsJson } from "../util/appBuilder"
 import { getNotLocalizedLicenseFile } from "../util/license"
 
 const certType = "Developer ID Installer"
@@ -237,7 +238,7 @@ export class PkgTarget extends Target {
       args.push("--scripts", scriptsDir)
     }
     if (plistInfo.length > 0) {
-      await executeAppBuilderAndWriteJson(["encode-plist"], { [propertyListOutputFile]: plistInfo })
+      SimplePlist.writeFileSync(propertyListOutputFile, packageInfo)
     }
 
     args.push(packageOutputFile)