Skip to content

Commit

Permalink
fix: Remove spctl check from Mac's notarization (#7361)
Browse files Browse the repository at this point in the history
  • Loading branch information
filfreire authored Jan 10, 2023
1 parent 1bd574b commit f9f23be
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/thin-bags-tap.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": major
---

Remove spctl check from Mac notarization step
4 changes: 1 addition & 3 deletions packages/app-builder-lib/src/macPackager.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import BluebirdPromise from "bluebird-lst"
import { deepAssign, Arch, AsyncTaskManager, exec, InvalidConfigurationError, log, use, getArchSuffix, spawn } from "builder-util"
import { deepAssign, Arch, AsyncTaskManager, exec, InvalidConfigurationError, log, use, getArchSuffix } from "builder-util"
import { signAsync } from "@electron/osx-sign"
import { SignOptions } from "@electron/osx-sign/dist/cjs/types"
import { mkdir, readdir } from "fs/promises"
Expand Down Expand Up @@ -488,8 +488,6 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
}
const options = this.generateOptions(appPath, appleId, appleIdPassword)
await notarize(options)
// Verify
await spawn("spctl", ["-a", "-t", "open", "--context", "context:primary-signature", "-v", `"${appPath}"`])
log.info(null, "notarization successful")
}

Expand Down

0 comments on commit f9f23be

Please sign in to comment.