Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - Ready for v0.2-beta #22

Merged
merged 59 commits into from
Dec 8, 2020
Merged

Dev - Ready for v0.2-beta #22

merged 59 commits into from
Dec 8, 2020

Conversation

stephenhensley
Copy link
Collaborator

@stephenhensley stephenhensley commented Dec 8, 2020

I think this is pretty much ready to go.

A few minor things that should happen prior to merge:

  • The windows-specific verbose logging cleanup done in PR #21 should be applied -- the output of the make commands is suppressed to avoid looking bad.
  • The Reverb example doesn't audibly do reverb on the pod because there's no access to the wet parameter -- is there a way to have this default to the default in gen~ (and add a default for that param), or rearrange the auto-mapped parameters so that the wet parameter can be accessed by knob1 on all platforms?
  • I'm not sure how to access the Pod LEDs, and yesterday we had talked about them not being enabled yet. So maybe we overlooked jumping back to this while getting everything else ready?

Otherwise everything is really smooth, and I haven't found any other show-stoppers.

@stephenhensley stephenhensley merged commit 91966d8 into main Dec 8, 2020
@stephenhensley stephenhensley deleted the dev branch December 8, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants