fix(desktop): restore upstream managed remote features - #24
100yenadmin merged 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@codex review Focus on the managed connection/binding escape boundary: client-selected gateway, raw token, customer/agent override, local-backend fallback, profile escape, Nous Cloud/updater contact, and whether unknown upstream HTTP/WebSocket passthrough stays confined to the server-assigned backend. Please review exact head 266a4e7 only. |
|
@codex review Current exact head is 6abf9bf. Delta-only review requested: CI exposed that brokerPost unrefed its timeout, allowing Node to exit while the request promise remained pending. The delta removes only timeout.unref(), so the broker timeout deterministically fires. Please confirm this fixes the lifecycle issue without weakening the managed connection/binding escape boundary. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Exact current head is 6744ba7. Delta-only review: CI found one stale test asserting the removed managed feature filter. The test now requires the upstream tool toggle/config plus MCP and Browse Hub surfaces. There is no production-code delta beyond the previously requested one-line timeout lifecycle fix. |
|
Independent semantic review completed on exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6744ba76ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert.match(chat, /onPickFiles=\{managedEva \? undefined : onPickFiles\}/) | ||
| assert.match(chat, /onTranscribeAudio=\{managedEva \? undefined : onTranscribeAudio\}/) | ||
| assert.doesNotMatch(settings, /managedViews/) | ||
| assert.match(chat, /onPickFiles=\{onPickFiles\}/) |
There was a problem hiding this comment.
Replace source-regex checks with behavior coverage
This updated assertion still verifies managed attachment behavior by reading src/app/chat/index.tsx as text and matching the prop spelling. When the ChatBar wiring is refactored or wrapped with equivalent runtime behavior, this test will fail on source shape rather than user-visible behavior; it can also pass while the rendered managed path is broken. Please exercise the managed ChatView/ChatBar behavior directly, or extract a small helper and test that instead.
AGENTS.md reference: AGENTS.md:L1380-L1384
Useful? React with 👍 / 👎.
Closes #18.
Outcome
Makes managed evaOS Agent a thin Electric Sheep envelope over upstream Hermes Desktop:
/api/*methods to the already assigned backend;2026.7.20-es.4.Proof
npm --prefix apps/desktop run test:managed— 28 passednpm --prefix apps/desktop run typecheck— passednpm --prefix apps/desktop run build— passedgit diff --check— passedThe managed contract includes unknown future HTTP and gateway-RPC passthrough tests plus negative connection/assignment escape tests.
Boundary
This PR does not change dashboard identity, ws-proxy binding, VM runtime isolation, Mac Access, OpenClaw, or the current distribution route. Signed/notarized artifact and installed customer proof remain in support-control #352 after merge.