Electric: add managed evaOS Teams identity broker login - #21
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pre-reset staging PR is closed as superseded by merged upstream-first reset PR #37 and the current thin-adapter tracker #1/#36. No code is being deleted. The branch and review history remain available. Retained behavior was replayed narrowly in #37; dropped managed brokers, blanket guards, duplicate UI, and control-signed routine collaboration must not be revived from this PR. |
Parent: #1
Closes #4
Summary
evaos-teams-managedbuild boundary for Electric Desktop device login, server-scoped Nostr key binding, entitlement refresh, relaunch, account switching, and atomic managed logoutevaos-teams-desktopOS Keychain service; expose only a safe status projection to the rendererDashboard prerequisite: electricsheephq/dashboard#707 at
5bf9baed7416338840f20fd2631041e5c391cf3d.Review remediation
logout_confirmedbefore any fallible local restore or wipe; confirmed recovery never depends on a second remote logoutnseccan be encoded or exportedevaos-teams://auth/callbackfallback through one strict callback primitive; register the custom scheme only in managed builds, propagate that overlay togenerate_context!(), and redact malformed URL logsValidation
Exact head:
357e4c43393278f5744dba97dd80cc000358798fcargo clippy --no-default-features --features evaos-teams-managed --lib --tests -- -D warnings: passedTAURI_CONFIGrustc overlay withbuzzandevaos-teams; native build output contains no overlaycargo check --lib: passedjust desktop-tauri-clippy: passedReview status
The bounded final review at
ed6127ebb48ef83eab69a2b6c7b621e4580ecbf1verified the four earlier blockers and found passive huddle expiry plus Tauri rustc propagation residuals. The owner-authorized surgical review at961652f181093d4e73d067f947b1cf775c64fdafverified the Tauri fix and found that the first audio-bound expiry watcher could die on reconnect and race refresh. The surgical review atc8b4ded43811e56c72718c79cd7760d55e27e9a3passed the entitlement generation/transition lifecycle, pipeline-drop ordering, and native correction, but found a supported initial-audio-handshake expiry race. The permitted final targeted delta review passed this exact head: the race is fixed, entitlement→huddle lock ordering is consistent and deadlock-free, and native behavior is unchanged.All verified findings have a terminal disposition in the #4 tracker update.
Proof boundary
This draft stages source only. It does not merge, deploy the dashboard/relay/VM, sign or publish an app, mutate customer/runtime state, or prove a canary. Provider authentication and setup remain Hermes authority and are checked only when Hermes launches.