Skip to content
This repository was archived by the owner on Aug 17, 2026. It is now read-only.

feat(agents): add Hermes ACP runtime - #17

Closed
100yenadmin wants to merge 2 commits into
mainfrom
feature/2-hermes-acp-runtime
Closed

feat(agents): add Hermes ACP runtime#17
100yenadmin wants to merge 2 commits into
mainfrom
feature/2-hermes-acp-runtime

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • add Hermes Agent to the Rust ACP runtime catalog with current install, skill, config, and avatar metadata
  • discover both hermes and hermes-acp, launching them with command-specific ACP arguments
  • model hermes acp --check as dependency readiness only, with no Hermes command-level authentication probe
  • preserve provider setup discovery through the existing bounded ACP initialize/auth-method handshake

Truth boundary

hermes acp --check can mark the runtime dependency surface ready or in need of setup. It never produces logged_in. Hermes provider authentication remains owned by Hermes and is discovered only when the ACP runtime is launched.

Focused validation

  • cargo test --manifest-path desktop/src-tauri/Cargo.toml hermes --lib -- --test-threads=1
  • cargo clippy --manifest-path desktop/src-tauri/Cargo.toml --lib -- -D warnings
  • cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --check
  • focused Biome check on changed TypeScript/TSX files
  • cd desktop && pnpm run typecheck
  • cd desktop && pnpm check:file-sizes

Scope

Generic upstream candidate only. No Electric Sheep, evaOS, Supabase, customer VM, or managed-business behavior.

Closes #2

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c40d36d-458b-4684-a1c3-9e1e30b87eb2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/2-hermes-acp-runtime

Comment @coderabbitai help to get the list of available commands.

@100yenadmin

Copy link
Copy Markdown
Member Author

Temporarily closing and reopening this draft to trigger the newly enabled canonical CI workflows; source head remains unchanged.

@100yenadmin 100yenadmin reopened this Jul 23, 2026
@100yenadmin

Copy link
Copy Markdown
Member Author

This pre-reset staging PR is closed as superseded by merged upstream-first reset PR #37 and the current thin-adapter tracker #1/#36.

No code is being deleted. The branch and review history remain available. Retained behavior was replayed narrowly in #37; dropped managed brokers, blanket guards, duplicate UI, and control-signed routine collaboration must not be revived from this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream: first-class Hermes ACP runtime in Buzz

1 participant