More cleanup #11
Draft
More cleanup #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
January 22, 2025 14:57
pmp-p
reviewed
Jan 30, 2025
| @@ -19446,7 +19446,7 @@ ac_config_files="$ac_config_files GNUmakefile src/Makefile.global" | |||
|
|
|||
|
|
|||
| ac_config_links="$ac_config_links src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION} src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION} src/include/pg_config_os.h:src/include/port/${template}.h src/Makefile.port:src/makefiles/Makefile.${template}" | |||
|
|
|||
| ac_config_links="$ac_config_links src/include/port/wasm_common.h:src/include/port/wasm_common.h" | |||
There was a problem hiding this comment.
try to avoid patching configure file, this file is auto generated whenever upstream update it with autotools and makes it hard for diff to apply. prefer add changes to CONFIG_SITE when it is possible
| @@ -240,15 +240,6 @@ END | |||
|
|
|||
| . ${PGROOT}/pgopts.sh | |||
|
|
|||
| # make sure no non-mvp feature gets in. | |||
There was a problem hiding this comment.
some compilers will try to use cpu intrinsics by default and some of them are allowed or emulated but outside MVP which may breaks compat on mobile browsers. Better force off to keep close to wasm MVP
pglite/cibuild/pgbuild.sh
Outdated
| END | ||
| fi | ||
| fi | ||
|
|
||
| if EM_PKG_CONFIG_PATH=$PREFIX/lib/pkgconfig CONFIG_SITE=${PGROOT}/config.site emconfigure $CNF --with-template=$BUILD | ||
| if EM_PKG_CONFIG_PATH=$PREFIX/lib/pkgconfig ac_cv_exeext=$ACCVEXEEXT emconfigure $CNF --with-template=$BUILD |
There was a problem hiding this comment.
please do not scatter autoconf modifiers, keep them in one file passed with CONFIG_SITE. this may be need to get homogenous build of third party libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleanups and simplifications.
Introduced a simple gh action to build postgres-pglite (postgres wasm).