Skip to content

Use the standard OTEL_RESOURCE_ATTRIBUTES env variables since Docker now supports it #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alco merged 2 commits into from
Nov 5, 2025
Merged

Use the standard OTEL_RESOURCE_ATTRIBUTES env variables since Docker now supports it #3346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad3497
Use the standard OTEL_RESOURCE_ATTRIBUTES env variables since Docker …
alco Oct 27, 2025
2f22c51
Fix the definition for postgres service in docker-compose-otel.yml
alco Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/sync-service/dev/docker-compose-otel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ services:
- ./postgres.conf:/etc/postgresql.conf:ro
- ./init.sql:/docker-entrypoint-initdb.d/00_shared_init.sql:ro
tmpfs:
- /var/lib/postgresql/data
- /var/lib/postgresql
- /tmp
entrypoint:
- docker-entrypoint.sh
Expand All @@ -27,7 +27,7 @@ services:
ELECTRIC_OTLP_ENDPOINT: http://otel:4318/
ELECTRIC_PROMETHEUS_PORT: ${ELECTRIC_PROMETHEUS_PORT:-4000}
DATABASE_URL: postgresql://postgres:password@postgres:5432/electric
OTEL_RESOURCE_ATTRIBUTES: ${OTEL_RESOURCE_ATTRIBUTES_FOR_DOCKER_COMPOSE}
OTEL_RESOURCE_ATTRIBUTES: ${OTEL_RESOURCE_ATTRIBUTES}
ports:
- 3000:3000
- 4000:4000
Expand All @@ -37,9 +37,7 @@ services:
ELECTRIC_HNY_DATASET: ${ELECTRIC_HNY_DATASET}
ELECTRIC_HNY_API_KEY: ${ELECTRIC_HNY_API_KEY}
PROMETHEUS_SCRAPE_ENDPOINT: electric:4000
# Need to set OTEL_RESOURCE_ATTRIBUTES_FOR_DOCKER_COMPOSE
# see https://github.com/docker/cli/issues/4958
OTEL_RESOURCE_ATTRIBUTES: ${OTEL_RESOURCE_ATTRIBUTES_FOR_DOCKER_COMPOSE}
OTEL_RESOURCE_ATTRIBUTES: ${OTEL_RESOURCE_ATTRIBUTES}
ports:
- 4317:4317
- 4318:4318
Expand Down
Loading