Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync-service): Fix bug with logical operators with 3 or more arguments #2225

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix(sync-service): Fix bug with logical operators with 3 or more arguments #2225

merged 3 commits into from
Jan 13, 2025

Conversation

robacourt
Copy link
Contributor

Fix for #2224

@robacourt robacourt marked this pull request as ready for review January 13, 2025 18:01
icehaunter
icehaunter approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@icehaunter icehaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the test have the braces so doesn't have that property?

@robacourt
Copy link
Contributor Author

Doesn't the test have the braces so doesn't have that property?

Oops, I was just checking the workaround worked but accidentally checked it in 🤦

Sorted now @icehaunter

@robacourt robacourt merged commit e29724e into main Jan 13, 2025
33 checks passed
@robacourt robacourt deleted the rob/fix-logical-operators-with-3-or-more-arguments branch January 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icehaunter icehaunter icehaunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robacourt @icehaunter