Add missing metric gathering to the telemetry poller config #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
force-pushed
the
alco/telemetry-config
branch
from
a8171b0 to
ad6443f
Compare
alco
force-pushed
the
alco/telemetry-config
branch
from
ad6443f to
547b3a3
Compare
icehaunter
reviewed
Dec 17, 2024
| @@ -204,7 +207,9 @@ defmodule Electric.Telemetry do | |||
| stack_id = Keyword.fetch!(opts, :stack_id) | |||
|
|
|||
| [ | |||
| # A module, function and arguments to be invoked periodically. | |||
| :memory, | |||
There was a problem hiding this comment.
Why do we need that? the memory stat collection already works (for sure it does bc it's what I use in benchmarks)
There was a problem hiding this comment.
so do RQL for that matter, and I'm assuming system counts too. Adding last_value to the prometheus is good though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2163.