Remap answers to MULTIPLE_TEXT questions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added support for remapping multiple_text answers
Don't want to introduce a backwards incompatible dependency to formly at this time
use == rather than in to prevent partial matches to answer_string from being removed from mapping
QueryDict in request.POST has already unquoted values
# Conflicts: # formly/tests/tests.py
# Conflicts: # formly/tests/tests.py # formly/tests/urls.py # formly/urls.py # formly/utils/views.py # formly/views/design.py # formly/views/results.py # formly/views/run.py # tox.ini
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 82.05% 82.94% +0.88%
==========================================
Files 15 16 +1
Lines 758 815 +57
Branches 110 122 +12
==========================================
+ Hits 622 676 +54
Misses 102 102
- Partials 34 37 +3
Continue to review full report at Codecov.
|
jacobwegner
changed the title
paltman
approved these changes
Apr 12, 2018
|
Cool stuff! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to "remap" answers to multiple text questions.
It also fixes a bug where
FieldResult.answervalues forMULTIPLE_TEXTquestions were being serialized/deserialized twice and provides a data migration to update previousMULTIPLE_TEXTanswers.Due to the backwards incompatible nature of the data migration, this will likely be released as part of formly 2.x.