Do not fail if whois.query returns None#115
Closed
bayandin wants to merge 1 commit intoelceef:masterfrom
bayandin:patch-1
Closed
Do not fail if whois.query returns None#115bayandin wants to merge 1 commit intoelceef:masterfrom bayandin:patch-1
bayandin wants to merge 1 commit intoelceef:masterfrom
bayandin:patch-1
Conversation
5 tasks
Owner
|
Although I can't reproduce this, you are right that it is possible to return None. Your change was committed in 5be9207. Thank you for contributing! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling for
Nonefromwhois.query(it looks like this is a legit behaviour https://github.com/DannyCork/python-whois/blob/0.9.7/whois/__init__.py#L73)Originally, the error was caught in one of Homebrew CI runs:
https://github.com/Homebrew/homebrew-core/pull/66472/checks?check_run_id=1517384199#step:6:3193