ext/har: add HAR logger extension #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port HAR logging from abourget/goproxy to ext package. Closes elazarl#609
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Dec 31, 2024
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 2, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
…e exportLoop, test viability,and package fixing
… into feature/har-logger
|
@ErikPelli Fixed up those errors I believe |
|
@CameronBadman the comment that I left for the tests has been resolved but I don't see the requested changes in the branch |
ErikPelli
reviewed
Jan 9, 2025
ext/har/logger_test.go
Outdated
Comment on lines
153
to
156
| assert.Equal(t, 3, len(exports), "should have 3 export batches") | ||
| assert.Equal(t, threshold, len(exports[0]), "first batch should have threshold size") | ||
| assert.Equal(t, threshold, len(exports[1]), "second batch should have threshold size") | ||
| assert.Equal(t, 1, len(exports[2]), "last batch should have remainder") |
There was a problem hiding this comment.
Since we are handling the batch in goroutines, we don't have anymore an enforced order. You have to adapt the assertion to expect two full batches and one with only one entry in any possible order.
ext/har/logger_test.go
Outdated
Comment on lines
124
to
126
| entriesCopy := make([]Entry, len(entries)) | ||
| copy(entriesCopy, entries) | ||
| exports = append(exports, entriesCopy) |
There was a problem hiding this comment.
Here there is a race condition, you are appending to a shared slice but there is no mutex to prevent concurrent accesses.
Add it to prevent this.
There was a problem hiding this comment.
not entirely sure if I have solved this one
ErikPelli
reviewed
Jan 9, 2025
Co-authored-by: Erik Pellizzon <[email protected]>
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
ErikPelli
reviewed
Jan 9, 2025
…ogger test to measure based on freq not a sorterd set
|
Thanks! LGTM. Tomorrow I'll do one final check and, if it will be ok, I will merge this pull request |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/har: add HAR logger extension
Port HAR (HTTP Archive) logging functionality from abourget/goproxy
to the ext/ package. Features include:
This is a self-contained extension that doesn't modify core functionality.
Credit to abourget/goproxy for the original implementation.
Closes #609