-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add m/monit icon #847
add m/monit icon #847
Conversation
add monit icon
Now it should be 20x20 with 2x2 offset, so there is a margin of 2 around all sides.
now monit is 20x20
Thanks to @rchiileea 's comment in #845 I now think I understand, so I updated this PR. I hope this is more to your liking! |
That was disappointing. Being shut down without do much as a comment. This interaction did not strike me as particularly friendly. |
sorry for the abrupt closing it was not wanted but it was simply a mistake. The choice of approval remains @rchiileea - I ask you to update your fork to be consistent with the latest update in case of merge @victorclaessen |
Good to hear. I have synced my pull request. Hoping for good news! (but willing to accept comments on how to make this contribution better, if necessary.) |
@elax46 check the main js to make sure its not missing anything, but this icon by @victorclaessen is how I wish all were done, nice clean lines no jagged edges, etc and correct format. @victorclaessen this is my bad for missing this but I have been busy with work and home remodel and work to pay for it and then done 58 icons in a few days so my bad. Thank you for the contribution and following instructions. |
I totally understand, and can relate. It's just that our initial interaction was perhaps a bit curt. Hope your project is going well. Thanks for accepting this. It's really useful to me! |
This time to the dev branch (replaces #845).
@rchiileea if you could be more specific in what is wrong with the svg, that would be much appreciated!