Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add m/monit icon #847

Merged
merged 5 commits into from
Jan 27, 2025
Merged

add m/monit icon #847

merged 5 commits into from
Jan 27, 2025

Conversation

victorclaessen
Copy link
Contributor

This time to the dev branch (replaces #845).

@rchiileea if you could be more specific in what is wrong with the svg, that would be much appreciated!

add monit icon
Now it should be 20x20 with 2x2 offset, so there is a margin of 2 around all sides.
now monit is 20x20
@victorclaessen
Copy link
Contributor Author

Thanks to @rchiileea 's comment in #845 I now think I understand, so I updated this PR.
I resized the logo to 20x20 and gave it an offset of 2x2 so that it now has a margin of 2 around all sides in the 24x24 box.

I hope this is more to your liking!

@elax46 elax46 requested a review from rchiileea December 3, 2024 22:02
@elax46 elax46 closed this Jan 26, 2025
@victorclaessen
Copy link
Contributor Author

That was disappointing. Being shut down without do much as a comment. This interaction did not strike me as particularly friendly.

@elax46 elax46 reopened this Jan 26, 2025
@elax46
Copy link
Owner

elax46 commented Jan 26, 2025

That was disappointing. Being shut down without do much as a comment. This interaction did not strike me as particularly friendly.

sorry for the abrupt closing it was not wanted but it was simply a mistake. The choice of approval remains @rchiileea - I ask you to update your fork to be consistent with the latest update in case of merge @victorclaessen

@victorclaessen
Copy link
Contributor Author

Good to hear. I have synced my pull request. Hoping for good news! (but willing to accept comments on how to make this contribution better, if necessary.)

@rchiileea
Copy link
Collaborator

@elax46 check the main js to make sure its not missing anything, but this icon by @victorclaessen is how I wish all were done, nice clean lines no jagged edges, etc and correct format. @victorclaessen this is my bad for missing this but I have been busy with work and home remodel and work to pay for it and then done 58 icons in a few days so my bad. Thank you for the contribution and following instructions.

@victorclaessen
Copy link
Contributor Author

I totally understand, and can relate. It's just that our initial interaction was perhaps a bit curt. Hope your project is going well. Thanks for accepting this. It's really useful to me!

@elax46 elax46 merged commit 373f645 into elax46:dev Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants