Replies: 33 comments 22 replies
-
Beta Was this translation helpful? Give feedback.
-
|
when you post in threads always tag me because I don't get notifications |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 Also I noticed from the iconfy site some of icons were too small and off to the left (I tried them in my preview manager and they showed up like this, I have donwloaded the ones that are like this into a folder and everytime I do a set ill do 10 to 15 corrections on them and keep file names the same so you know which ones to change. |
Beta Was this translation helpful? Give feedback.
-
ok I kindly ask you to separate the icons into two different zips, one for modifying and the other for adding new ones |
Beta Was this translation helpful? Give feedback.
-
|
260284.zip |
Beta Was this translation helpful? Give feedback.
-
|
Valid for the next version they have already been added |
Beta Was this translation helpful? Give feedback.
-
|
Also you may want to look at the coding as it seems other icon and repos have adjusted theres lately ours currently looks like this
were theres would look like this and might be something needed to adapt to fix some issues
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for your work as always, but I didn't understand what was changed compared to the other projects |
Beta Was this translation helpful? Give feedback.
-
|
by the looks of it, its just the spacing of the in the java, but also if you open our js and compare to others in visual its spaced differently too on the code side, it might be nothing but I have compared to a few files now and they all our simular. ours is different |
Beta Was this translation helpful? Give feedback.
-
|
it's just a question of indentation it's nothing functional but just to make the code "nicer to look at" |
Beta Was this translation helpful? Give feedback.
-
|
@rchiileea Personal request :) in the next version could you create two small icons of the P1S and A1 Mini bambulab? I need them as icons for smart sockets |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 you mean something like this? |
Beta Was this translation helpful? Give feedback.
-
|
That's great! |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
it's great! Thank you |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
all the fixed ones are I forgot to remove the surround... doh, so expect 20 in new update of fixed icons :( doh |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 see above post lol, here they all are fixed and then new ones added, if at all possible can we get these icons tonight or in the morning so I can share tomorrow on release party (contain quite a few stairs icons for the new floors introduced in 2024.4) |
Beta Was this translation helpful? Give feedback.
-
|
toofix.zip |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@elax46 these icons in the list need changing, but luckily you only need to change view box in the file viewbox changes in json file all changed to 0 0 24 24 sync-box only view box needs changing as they sit to the left in apps using iconify and your web app, these have to be changed. then the bad news Then their should only be 80 odd that will need resizing due to the fact they range from 128 128 viewbox up too (which shcked me) 5000 5000 view box (and explains why some of the icons are not visible in your web based app at all, I expect the 32x23 ones are the ones that only show part of the icon).... but these could be a explination of why people have caching issues too. So first correct the icons listed above to view box 0 0 24 24 do not correct any others, then change your web app view box to 0 0 32 32 Then I will go through the list again and download all the files above that to correct, once this is done If we get any caching issues of icons from users moving forward I will have to resize the ones that are 0 0 32 32... But I am hoping the HA app will accept that size and i dont have to as 50 icons to correct is much better than 214. |
Beta Was this translation helpful? Give feedback.
-
|
thanks for your detailed analysis, I will fix the viewboxes of the icons you indicated and check the issue on the icon site to understand if I can modify the code in relation to the icon viewbox without setting a static viewbox |
Beta Was this translation helpful? Give feedback.
-
|
update: I corrected all the icons you indicated, I also updated the code to find the icons with the viewbox and at 32x32 it seems to work for many icons but several still look bad so they need to be modified |
Beta Was this translation helpful? Give feedback.
-
|
icons with problems:
|
Beta Was this translation helpful? Give feedback.
-
|
lol I am going to busy, thanks for saving me the time of going through them, I knew there would be a few. |
Beta Was this translation helpful? Give feedback.
-
|
take all the time you need |
Beta Was this translation helpful? Give feedback.
-
|
back from break, so i went through again my self and found 130 that need adjusting/fixing in total lol |
Beta Was this translation helpful? Give feedback.
-
|
so been busy, I had to redo a lot of these completely as they had way to many points some had 1000 points, all the arlo stuff has been redone, fixed points on some of the other stuff and redone all the battery ones, redone the apple ones too only 75 to go |
Beta Was this translation helpful? Give feedback.
-
|
2 hours of work! Anyway, thank you always for your support |
Beta Was this translation helpful? Give feedback.
-
|
latest requests and redone |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 omg I have been busy in spare time, so many icons I actually redone most of them too so they had much few anchors, some that were over 1mb are now 2kb... some like the sonos obviously could not be changed due to the grill effect they have. I then had a blast from the past redoing the moes ones as those are icons I requested after donating a long time ago now, way before i taught myself to do icons lol.. new icons are will be uploaded tomorrow hopefully this will help with caching and sizing issues for your web icon browser |
Beta Was this translation helpful? Give feedback.
-
remarkable work for both |
Beta Was this translation helpful? Give feedback.
-
|
From the icon creator it seems that there are still some icons that are not visible @rchiileea
|
Beta Was this translation helpful? Give feedback.
-
|
@elax46 is everything alright bud are you ok? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, everything is ok. I didn't release the version of the fixed icons because I was waiting for the new ones |
Beta Was this translation helpful? Give feedback.
-
|
Fix may 14 post had most of the new ones in 🤣
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Emanuele ***@***.***>
Sent: Sunday, June 23, 2024 3:44:40 PM
To: elax46/custom-brand-icons ***@***.***>
Cc: Richard Bowzer ***@***.***>; Mention ***@***.***>
Subject: Re: [elax46/custom-brand-icons] Latest requests done (Discussion #542)
Yes, everything is ok. I didn't release the version of the fixed icons because I was waiting for the new ones
—
Reply to this email directly, view it on GitHub<#542 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AU4KVP6X67MZJSPHLJ35X5DZI3NNRAVCNFSM6AAAAABCPZQPROVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TQNJSGMZTM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
update.and.two.fixed.icons.zip |
Beta Was this translation helpful? Give feedback.
-
|
@rchiileea
|
Beta Was this translation helpful? Give feedback.
-
|
my bad I thought I had uploaded all the new icons :( added the two new requests but created a generic battery back up, also two icons left to fix are in there redesigned. |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 added new icon requests as well as a few others including smart camera motion (car/person/pet) icons |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 |
Beta Was this translation helpful? Give feedback.
-
|
thanks for your work! |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 sorry big update for you :( all the latest requests done plus the adition of the boca junior one in pull request done correctly, I have also added 13 of the twinkly brand lights as well as the logo (14 in total) edit forgot the panasonic icon @elax46 |
Beta Was this translation helpful? Give feedback.
-
|
The twinkly-festoon and twinkly-c9 icons have a double path @rchiileea |
Beta Was this translation helpful? Give feedback.
-
|
@elax46 fixed |
Beta Was this translation helpful? Give feedback.
-
|
081024.zip |
Beta Was this translation helpful? Give feedback.
-
29-01-24.zip
Beta Was this translation helpful? Give feedback.
All reactions