Merged
Conversation
Contributor
Author
|
Additionally, I need to check if the diags by value issue is also in all the utils/tfsdk.go helper methods. |
tobio
reviewed
Oct 21, 2024
Member
tobio
left a comment
There was a problem hiding this comment.
👍 couple of minor comments on the code.
Co-authored-by: Toby Brain <tobio85@gmail.com>
Co-authored-by: Toby Brain <tobio85@gmail.com>
Co-authored-by: Toby Brain <tobio85@gmail.com>
Co-authored-by: Toby Brain <tobio85@gmail.com>
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Nov 19, 2024
* fix epm * changelog * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <tobio85@gmail.com> * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <tobio85@gmail.com> * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <tobio85@gmail.com> * Update internal/clients/fleet/fleet.go Co-authored-by: Toby Brain <tobio85@gmail.com> * import and formatting * i should really fmt locally first --------- Co-authored-by: Toby Brain <tobio85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So there's a number of problems that cropped up.
allOf.1needs to be under.itemwhich is present inallOf.0. All the more reason to get the Pull newer fleet schema #834 to a satisfactory state.Actual:
Expected (using ti_abusech on one of the older stack versions):