Add support for remote_indicies to elasticstack_elasticsearch_security_role & elasticstack_kibana_security_role

[mholttech]

resolves #722 by adding remote_indices to elasticstack_kibana_security_role & elasticstack_elasticsearch_security_role

[cla-checker-service]

💚 CLA has been signed

[tobio]

It looks like the build is failing because the committed docs don't match what would be generated. Are you able to run make docs-generate and commit the result?

[tobio]

The linked issue talks about the elasticsearch role resource (which is here). I'm not sure if adding it to the Kibana role is sufficient for you though?

[mholttech]

Good catch. I didn't realize there was two seperate resources. Looks like the api for elasticstack_kibana_security_role is in preview but the work done is still valid. I'll expand the PR to include the intended resource and regenerate the docs.

[mholttech]

Everything should be in place for the elasticstack_kibana_security_role now. Still working on the elasticstack_elasticsearch_security_role

[mholttech]

forgot about TestAccDataSourceKibanaSecurityRole, i've commented out the remote_indices for now, will add the version constraints tomorrow.

[mholttech]

@tobio This is ready for another review

[tobio]

Couple of minor comments. Generally this LGTM. Thanks so much for adding this! It's a decent chunk of code here. ❤️

[mholttech]

Couple of minor comments. Generally this LGTM. Thanks so much for adding this! It's a decent chunk of code here. ❤️

Thanks! I've reviewed your feedback and now that i've learned how everything works and it's in a working state I'll attempt some of the suggested code cleanup in indices and remote_indices before we merge this.

[mholttech]

@tobio I just pushed some code improvements based on your feedback.

[tobio]

LGTM. This is a big chunk of code, thanks for adding this to the provider!

[mholttech]

@tobio when will the next version be released so we can begin leveraging this?

[tobio]

@mholttech I'm expecting these to be released ideally later this week, but by the end of next week at the latest.