Bump provider support to ES version 8.x
#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
added
bug
JoshMock
previously approved these changes
Feb 17, 2022
Member
JoshMock
left a comment
JoshMock
left a comment
There was a problem hiding this comment.
All seems relatively straightforward 👍
|
|
||
| // 8.x workaround | ||
| hasAllowCustomRouting := false | ||
| //for _, s := range []interface{}{old} { |
| } | ||
| } | ||
| } | ||
| // } |
Crazybus
approved these changes
Feb 21, 2022
Contributor
Crazybus
left a comment
Crazybus
left a comment
There was a problem hiding this comment.
LGTM!
make sure the index template still works with both 7.x and 8.x
Is the plan to also add CI tests for 7.x? Right now everything works but I can imagine future changes that might accidentally break 7.x support accidentally.
Contributor
Author
Yep, as a followup I want to create something like matrix testing for different ES versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
7.xand8.xdata_streamsection ofindex_templateallow_custom_routing, which appeared only in8.x7.xand8.x8.0.0so the all new resources will be defaulting to newest releases of Elasticsearch