Skip to content

Populate policy_id when importing fleet policies and integrations#646

Merged
tobio merged 1 commit intoelastic:mainfrom
GeorgeGkinis:populate_policy_id
May 29, 2024
Merged

Populate policy_id when importing fleet policies and integrations#646
tobio merged 1 commit intoelastic:mainfrom
GeorgeGkinis:populate_policy_id

Conversation

@GeorgeGkinis
Copy link
Contributor

Populates policy_id when importing fleet policies and integrations.

This enables to update fleet policies in-place when using an import block.

Solves #496

@cla-checker-service
Copy link

cla-checker-service bot commented May 28, 2024

💚 CLA has been signed

@GeorgeGkinis
Copy link
Contributor Author

I have signed the CLA but it is not reflected here.

Please accept the CLA or let a maintainer perform this fix.

@tobio
Copy link
Member

tobio commented May 28, 2024

I have signed the CLA but it is not reflected here.

The commits in this PR are authored by a different email to that used to sign the CLA, and doesn't appear to be linked to your GH profile. If you re-author these commits with the gmail account used to sign the CLA then it should be reflected here.

@tobio
Copy link
Member

tobio commented May 29, 2024

@GeorgeGkinis are you able to re-author the commits here with a different email address?

@GeorgeGkinis
Copy link
Contributor Author

@GeorgeGkinis are you able to re-author the commits here with a different email address?

@tobio
Indeed :)

CLA is now accepted.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for taking the time to fix this up!

@GeorgeGkinis
Copy link
Contributor Author

Thanks for accepting this.

Could you give an approximate indication for when this will be available so I can communicate with the rest of the team?

@tobio tobio merged commit c31de6d into elastic:main May 29, 2024
@tobio
Copy link
Member

tobio commented May 29, 2024

Could you give an approximate indication for when this will be available

I don't have a time frame we can share at the moment unfortunately. Generally provider releases are made based on the utility of unreleased changes, and currently this PR is the only unreleased change so it could be a while.

@GeorgeGkinis GeorgeGkinis deleted the populate_policy_id branch May 29, 2024 11:27
@GeorgeGkinis
Copy link
Contributor Author

I noticed that the files touched by this commit have CRLF line endings.

@tobio
Copy link
Member

tobio commented Jun 12, 2024

@GeorgeGkinis I'm hoping to make a new provider release over the next few days if that helps your planning.

@GeorgeGkinis
Copy link
Contributor Author

@tobio I see that 0.11.4 is released.
Awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments