Skip to content

Conversation

@tobio
Copy link
Member

@tobio tobio commented Mar 21, 2024

Fixes #439

Elasticsearch supports both a string array (what the provider has been expecting) and a CSV list for the indices field on an SLM policy. This PR customises the JSON marshaller to ensure both formats are parsed into a Go slice.

@tobio tobio requested review from a team and dimuon March 21, 2024 07:18
@tobio tobio self-assigned this Mar 21, 2024
@tobio tobio force-pushed the support-csv-indices branch from f8e6bdb to 04c811b Compare March 21, 2024 07:20
dimuon
dimuon previously approved these changes Apr 5, 2024
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (just changelog)

@tobio tobio merged commit c74d33f into main Apr 6, 2024
@tobio tobio deleted the support-csv-indices branch April 6, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] elasticstack_elasticsearch_snapshot_lifecycle: Problem with indicies

3 participants