Merged
Conversation
The generated code still has some drawbacks: - ModelMap structure is missing (it's defined manually) - OneOf generates a golang struct with promoted fields where each field represent one of the options. The generated client cannot properly encode such structs.
Kushmaro
reviewed
Apr 24, 2023
Ogen cannot generate code for `oneOf` without discriminator or unique fields. This is the problem for Update where payload doesn't and should not have `connector_type_id` field that is the only candidate for discriminator.
plus fix of minimum support version for tines
Contributor
Author
|
@tobio , can you please have a look at this? |
tobio
reviewed
May 17, 2023
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
LGTM, couple of small questions. There's so much work here 👍 👍 👍
Contributor
Author
|
@tobio , I addressed all comments, I believe. Can you please have a look and approve it? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #46.
Adds support for a Kibana action connectors based on a generated Kibana client. The client is generated from Kibana OpenAPI specs similar to #292.
Please refer to README for more details and known issues.