Skip to content

Enrich Policy Resource #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobio merged 15 commits into from
Mar 22, 2023
Merged

Enrich Policy Resource #286

tobio merged 15 commits into from
Mar 22, 2023

Conversation

@jonjitsu
Copy link
Contributor

@jonjitsu jonjitsu commented Mar 13, 2023

This PR starts adding in support for the enrich API #282 . It adds a new resource elasticstack_elasticsearch_enrich_policy.

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 13, 2023 •
edited
Loading

💚 CLA has been signed

@jonjitsu
Copy link
Contributor Author

jonjitsu commented Mar 13, 2023 •
edited
Loading

I've signed the contributor agreement 3 times. Once today and twice a couple weeks ago when I created the 2 character PR to fix the Makefile. I'm not sure what the next steps are to make the CLA bot happy.

I know I've missed updating a bunch of documentation. If someone can give me some guidance, that would be great.
@tobio

@tobio
Copy link
Member

tobio commented Mar 14, 2023

I'm not sure what the next steps are to make the CLA bot happy.

I can see the signature against the @jonjitsu handle. It looks like the email address associated with the commits in this PR isn't publicised in you're GH handle and so it's not linking up with the CLA sig.

You can either rewrite the commits with the existing email associated with @jonjitsu, or include your Gmail address in your GH profile so it gets linked correctly.

tobio
tobio reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for taking the time to put this change together. Couple of small comments inline.

@jonjitsu jonjitsu force-pushed the feature/elasticsearch-enrich-api branch from 5f9e6b8 to 8564bb3 Compare March 14, 2023 19:07
@jonjitsu jonjitsu changed the title WIP: Enrich API Enrich Policy Resource Mar 17, 2023
@jonjitsu jonjitsu requested a review from tobio March 21, 2023 15:24
tobio
tobio approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for all your effort here. This is awesome!

@tobio tobio merged commit 3a116bb into elastic:main Mar 22, 2023
tobio added a commit that referenced this pull request Mar 22, 2023
@tobio
Merge remote-tracking branch 'origin/main' into alert-rules
617be68 
* origin/main:
  [ISSUE-154] Add Watches (#155)
  Bump actions/setup-go from 3 to 4 (#288)
  Enrich Policy Resource (#286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobio tobio tobio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonjitsu @tobio