Add security role data source#177
Merged
Merged
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
k-yomo
force-pushed
the
add-role-data-source
branch
5 times, most recently
from
da43669 to
b0b5086
Compare
k-yomo
force-pushed
the
add-role-data-source
branch
from
b0b5086 to
d07ce1b
Compare
tobio
previously approved these changes
Oct 30, 2022
|
|
||
| ### Added | ||
| - New resource `elasticstack_elasticsearch_logstash_pipeline` to manage Logstash pipelines ([Centralized Pipeline Management](https://www.elastic.co/guide/en/logstash/current/logstash-centralized-pipeline-management.html)) ([#151](https://github.com/elastic/terraform-provider-elasticstack/pull/151)) | ||
| - Add`elasticstack_elasticsearch_security_role` data source ([#177](https://github.com/elastic/terraform-provider-elasticstack/pull/177)) |
Member
There was a problem hiding this comment.
Suggested change
| - Add`elasticstack_elasticsearch_security_role` data source ([#177](https://github.com/elastic/terraform-provider-elasticstack/pull/177)) | |
| - Add `elasticstack_elasticsearch_security_role` data source ([#177](https://github.com/elastic/terraform-provider-elasticstack/pull/177)) |
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "elasticstack_elasticsearch_security_role Data Source - terraform-provider-elasticstack" | ||
| subcategory: "" |
Member
There was a problem hiding this comment.
Suggested change
| subcategory: "" | |
| subcategory: "Security" |
tobio
reviewed
Oct 31, 2022
|
|
||
| # Data Source: elasticstack_elasticsearch_security_role | ||
|
|
||
| Use this data source to information about existing Elasticsearch role. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-get-role.html |
Member
There was a problem hiding this comment.
Suggested change
| Use this data source to information about existing Elasticsearch role. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-get-role.html | |
| Use this data source to get information about an existing Elasticsearch role. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-get-role.html |
Maybe there's other words you intended to have here, happy to use those instead too :)
Contributor
Author
There was a problem hiding this comment.
Whoops, I guess I just deleted it by mistake, fixed🙏
6ec61a4
Contributor
Author
|
Ah, I'll fix merge conflict after another PR gets merged |
tobio
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #82
This PR adds security role data-source in reference to existing security role resource.
https://github.com/elastic/terraform-provider-elasticstack/blob/main/internal/elasticsearch/security/role.go