Add elasticstack_elasticsearch_security_role_mapping resource #148
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
k-yomo
force-pushed
the
support-security-role-mapping
branch
3 times, most recently
from
dab7e80 to
05e5460
Compare
k-yomo
force-pushed
the
support-security-role-mapping
branch
from
05e5460 to
728ab6f
Compare
|
jenkins test this |
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
We should include role_templates in the resource. Otherwise this looks great, thanks!
| } | ||
|
|
||
| func (a *ApiClient) GetElasticsearchRoleMapping(ctx context.Context, roleMappingName string) (*models.RoleMapping, diag.Diagnostics) { | ||
| req := a.es.Security.GetRoleMapping.WithName(roleMappingName) |
There was a problem hiding this comment.
Can't we chain the WithContext call here?
There was a problem hiding this comment.
No, it's not possible...!
| Type: schema.TypeString, | ||
| Required: true, | ||
| DiffSuppressFunc: utils.DiffJsonSuppress, | ||
| Description: "A list of mustache templates that will be evaluated to determine the role names that should granted to the users that match the role mapping rules. This matches fields of users, rules can be grouped into `all` and `any` top level keys.", |
There was a problem hiding this comment.
This description is for role_templates which is missing from the resource schema.
|
Also needs a change log entry here :) |
|
@k-yomo thanks for the groundwork here. Just wanted to check if you're still able to continue on with this one? If not are you ok with me adding the final changes to support |
|
@tobio |
|
jenkins test this |
|
jenkins test this |
|
@dimuon are you able to take a look at the changes in this one? |
I'll take a look |
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "elasticstack_elasticsearch_security_role_mapping Resource - terraform-provider-elasticstack" | ||
| subcategory: "" |
5 participants
Resolves #47