Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: efficient journey bundling and hashing #809

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jul 26, 2023

  • fix fix: update hash logic to account for bundling #804 correctly
  • The previous solution of updating the bundle hash based on the file contents is problematic due to the following reasons
    • The bundle would contain both journeys because they are in same file
    • If one of the journey imports big external lib, it affects the size of others as well.
    • The more external deps, the bigger the problem and every change would indirectly affect the Kibana SO updates.
  • The proposed solution addresses the problem by adding a pre-transform phase where we help the bundler (esbuild) to do better DCE (Dead Code elimination) on individual journey functions as bundlers work on file level entries not lower levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant