Skip to content

Comments

[Docs][SIEM] Cases UI docs#967

Merged
benskelker merged 34 commits intoelastic:masterfrom
benskelker:siem_cases_ui
Apr 3, 2020
Merged

[Docs][SIEM] Cases UI docs#967
benskelker merged 34 commits intoelastic:masterfrom
benskelker:siem_cases_ui

Conversation

@benskelker
Copy link
Contributor

@benskelker benskelker commented Apr 1, 2020

@benskelker benskelker mentioned this pull request Apr 1, 2020
10 tasks
@benskelker benskelker marked this pull request as ready for review April 2, 2020 06:45
@cnasikas
Copy link
Member

cnasikas commented Apr 2, 2020

Hi! Great job!

Some notes:

  • The on edit and update options determines how a field should be updated. The option can have three values: overwritten, appended (the updated value will be appended to the original value), and nothing (nothing will happen). When a comment is edited on SIEM a new comment will be created on ServiceNow (this means that the edited comment is appended). I think the phrase When a new comment is added to a SIEM case should change to When a new comment is updated...

  • Configuring external connections should explain what closure options are and how you can update a connector.

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benskelker benskelker merged commit 9059d7b into elastic:master Apr 3, 2020
@benskelker benskelker deleted the siem_cases_ui branch April 3, 2020 05:41
benskelker added a commit to benskelker/stack-docs that referenced this pull request Apr 3, 2020
* intial case api docs

* starts updating the api

* updates patch comments

* api updates

* starts conf api

* more conf api stuff

* minor fixes

* more updates

* proofing

* typo

* formatting

* gets rid of me

* adds delete all comments method

* corrections after feedback

* corrections 2

* corrections continued

* cmore corrections

* and more corrections

* even more

* rebase

* adds reporters to find

* corrections

* corrections II

* connector corrections

* final corrections

* starts cases ui

* image and stuff

* open and manage cases

* connectors

* proofing and ui overview

* starts corrections

* corrections

* more corrections
benskelker added a commit to benskelker/stack-docs that referenced this pull request Apr 3, 2020
* intial case api docs

* starts updating the api

* updates patch comments

* api updates

* starts conf api

* more conf api stuff

* minor fixes

* more updates

* proofing

* typo

* formatting

* gets rid of me

* adds delete all comments method

* corrections after feedback

* corrections 2

* corrections continued

* cmore corrections

* and more corrections

* even more

* rebase

* adds reporters to find

* corrections

* corrections II

* connector corrections

* final corrections

* starts cases ui

* image and stuff

* open and manage cases

* connectors

* proofing and ui overview

* starts corrections

* corrections

* more corrections
benskelker added a commit that referenced this pull request Apr 3, 2020
* intial case api docs

* starts updating the api

* updates patch comments

* api updates

* starts conf api

* more conf api stuff

* minor fixes

* more updates

* proofing

* typo

* formatting

* gets rid of me

* adds delete all comments method

* corrections after feedback

* corrections 2

* corrections continued

* cmore corrections

* and more corrections

* even more

* rebase

* adds reporters to find

* corrections

* corrections II

* connector corrections

* final corrections

* starts cases ui

* image and stuff

* open and manage cases

* connectors

* proofing and ui overview

* starts corrections

* corrections

* more corrections
benskelker added a commit that referenced this pull request Apr 3, 2020
* intial case api docs

* starts updating the api

* updates patch comments

* api updates

* starts conf api

* more conf api stuff

* minor fixes

* more updates

* proofing

* typo

* formatting

* gets rid of me

* adds delete all comments method

* corrections after feedback

* corrections 2

* corrections continued

* cmore corrections

* and more corrections

* even more

* rebase

* adds reporters to find

* corrections

* corrections II

* connector corrections

* final corrections

* starts cases ui

* image and stuff

* open and manage cases

* connectors

* proofing and ui overview

* starts corrections

* corrections

* more corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants