-
Notifications
You must be signed in to change notification settings - Fork 327
It drops support for Python3.9, it add support for Python 3.13, and it drops nox dependencies in favor of uv. #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
665557f
Revert "Allow configuring the process startup method to be used for c…
fressi-elastic 41a544a
Merge branch 'master' of github.com:elastic/rally
fressi-elastic 0925770
Merge branch 'master' of github.com:elastic/rally
fressi-elastic d32aee7
Add support for Python3.13 (pass unit tests).
fressi-elastic dff998d
Revert unnecessary changes.
fressi-elastic 8e4f56f
Revert unnecessary changes.
fressi-elastic df04aa1
Revert unnecessary changes.
fressi-elastic 91ae14a
Update the uv.lock file.
fressi-elastic f2965c7
Add entries for Python v3.13 to the CI testing matrix.
fressi-elastic e37d7b9
It drops support for Python 3.9
fressi-elastic 7f4fee3
Fix docs/migrate.rst
fressi-elastic 4ca911d
Remove statement: from __future__ import annotations
fressi-elastic cb01f3a
Fix esrally/track/params.py and update uv.lock file.
fressi-elastic 001f33b
Revert changes to esrally/storage/_range.py
fressi-elastic 78d294f
Skip testing version 3.12 in buildkite pipeline.
fressi-elastic 4f20116
Fix some other annotation and one pylint founding.
fressi-elastic 9e217ef
Update CI python versions file.
fressi-elastic 23e1314
Remove unnecessary changes.
fressi-elastic ab11c9b
Update CI python versions.
fressi-elastic 4e06935
Set Python3.13 as the default version.
fressi-elastic 45a9015
Let `make test` and `make it` use python 3.13
fressi-elastic 0e9cc67
Add standard-imghdr because imghdr has been removed from python 3.13
fressi-elastic 48f3da0
Update docker image version.
fressi-elastic 0699feb
Use managed python version for preparing venv directory.
fressi-elastic 8c75c66
Refactor Makefile:
fressi-elastic 073d5f4
Add goal to run IT for serverless.
fressi-elastic 210565c
Add goal for rally_tracks_compat
fressi-elastic bf47095
Fix PHONY goals.
fressi-elastic 7ff36ad
Update python versions for mypy and black
fressi-elastic 6cbea73
Update .buildkite pipeline files.
fressi-elastic e3f2857
Fix UV installation step.
fressi-elastic 0678a19
Debug CI scripts
fressi-elastic 6fbff06
Fix Dockerfile and CI scripts.
fressi-elastic d2ffdb5
Fix VENV path in Dockerfile.
fressi-elastic a92dbf6
Use levacy VIRTUAL_ENV as name for VENV_DIR
fressi-elastic 5ceb63e
Force Python version when running it_serverless test cases.
fressi-elastic 35a216f
Export PY_VERSION as an environment variable.
fressi-elastic 930ac3a
Update uv version in Docerfile.
fressi-elastic caea1a3
It drops the check for max python version.
fressi-elastic 9dea73e
Drop dependency on tox/nox.
fressi-elastic a08fa72
It ensures the rally plugin is installed before using for tests.
fressi-elastic f408e14
It renames Makefile goal rally_tracks_compat -> it_tracks_compat
fressi-elastic a7a0e6e
It adds some comment in the Makefile.
fressi-elastic 9b38493
Remove unnecessary requirements and update wheel version.
fressi-elastic 70a88c2
Update Makefile error message.
fressi-elastic 3f943fe
Update add_missing_loggers_to_config to make it a little easier to read.
fressi-elastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eo pipefail | ||
| set -exo pipefail | ||
|
|
||
| source .buildkite/retry.sh | ||
|
|
||
|
|
@@ -17,22 +17,26 @@ export DEBIAN_FRONTEND=noninteractive | |
| sudo mkdir -p /etc/needrestart | ||
| echo "\$nrconf{restart} = 'a';" | sudo tee -a /etc/needrestart/needrestart.conf > /dev/null | ||
|
|
||
| PYTHON_VERSION="$1" | ||
| export PY_VERSION="$1" | ||
| TEST_NAME="$2" | ||
|
|
||
| echo "--- System dependencies" | ||
|
|
||
| retry 5 sudo add-apt-repository --yes ppa:deadsnakes/ppa | ||
| retry 5 sudo apt-get update | ||
| retry 5 sudo apt-get install -y \ | ||
| "python${PYTHON_VERSION}" "python${PYTHON_VERSION}-dev" "python${PYTHON_VERSION}-venv" \ | ||
| dnsutils # provides nslookup | ||
| "python${PY_VERSION}" "python${PY_VERSION}-dev" "python${PY_VERSION}-venv" \ | ||
| make \ | ||
| dnsutils # provides nslookup | ||
|
|
||
| echo "--- Python modules" | ||
| echo "--- Install UV" | ||
|
|
||
| "python${PYTHON_VERSION}" -m venv .venv | ||
| source .venv/bin/activate | ||
| pip install nox | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| source "${HOME}/.local/bin/env" | ||
|
|
||
| echo "--- Create virtual environment" | ||
|
|
||
| make venv | ||
gbanasiak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| echo "--- Run IT serverless test \"$TEST_NAME\" :pytest:" | ||
|
|
||
|
|
@@ -45,12 +49,13 @@ export THESPLOG_THRESHOLD="INFO" | |
|
|
||
| trap upload_logs ERR | ||
|
|
||
|
|
||
| case $TEST_NAME in | ||
| "user") | ||
| nox -s it_serverless | ||
| make -s it_serverless | ||
|
Comment on lines
-50
to
+55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not intentional! It's a mistake. |
||
| ;; | ||
| "operator") | ||
| nox -s it_serverless -- --operator | ||
| make -s it_serverless "ARGS=--operator" | ||
| ;; | ||
| *) | ||
| echo "Unknown test type." | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| { | ||
| "python_versions": { | ||
| "PY39": "3.9.16", | ||
| "PY310": "3.10.10", | ||
| "PY311": "3.11.7", | ||
| "PY312": "3.12.2", | ||
| "MIN_PY_VER": "3.9.16", | ||
| "DEFAULT_PY_VER": "3.12.2" | ||
| "PY310": "3.10.18", | ||
| "PY311": "3.11.13", | ||
| "PY312": "3.12.11", | ||
| "PY313": "3.13.7", | ||
| "MIN_PY_VER": "3.10.0", | ||
| "DEFAULT_PY_VER": "3.13.7" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.