Fix ITs after pytest-rally plugin modification#1977
Merged
gbanasiak merged 2 commits intoelastic:masterfrom Sep 18, 2025
Merged
Fix ITs after pytest-rally plugin modification#1977gbanasiak merged 2 commits intoelastic:masterfrom
gbanasiak merged 2 commits intoelastic:masterfrom
Conversation
gbanasiak
commented
Sep 17, 2025
Comment on lines
45
to
46
| if config.option.track_revision is None: | ||
| config.option.track_revision = "master" |
Contributor
Author
There was a problem hiding this comment.
We can probably skip this one as plugin default will work?
NickDris
requested changes
Sep 18, 2025
Contributor
NickDris
left a comment
NickDris
left a comment
There was a problem hiding this comment.
The default value of track_revision of pytest-rally is None. So in order to maintain the former functionality we should change be adding 'master' either on pytest-rally or in conftest.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns Rally with elastic/pytest-rally#5.