Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update progress after GCS download finished #1698

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update progress after GCS download finished #1698

merged 1 commit into from
Apr 3, 2023

Conversation

danielmitterdorfer
Copy link
Member

With this commit we ensure that the progress indicator is updated once again after a download from a GCS bucket has finished.

@danielmitterdorfer
Update progress after GCS download finished
1224f22 
With this commit we ensure that the progress indicator is updated once
again after a download from a GCS bucket has finished.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like labels Mar 31, 2023
@danielmitterdorfer danielmitterdorfer added this to the 2.8.0 milestone Mar 31, 2023
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 31, 2023
@danielmitterdorfer
Copy link
Member Author

I noticed this because on a new track that I've created I always saw this after the track data have been downloaded and I was puzzled why it wouldn't say 100%.

[INFO] Downloading track data (2.2 GB total size)                                 [ 98.9%]

With this change:

[INFO] Downloading track data (2.2 GB total size)                                [100.0%]

@dliappis dliappis self-requested a review March 31, 2023 09:45
dliappis
dliappis approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching this

@danielmitterdorfer danielmitterdorfer merged commit 1d1e1f9 into elastic:master Apr 3, 2023
@danielmitterdorfer danielmitterdorfer deleted the fix-gcs-progress branch April 3, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis