Skip to content

CI determines Elasticsearch build arguments using unified job in gh workflow [stateful] #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickDris merged 4 commits into from
Nov 21, 2025
Merged

CI determines Elasticsearch build arguments using unified job in gh workflow [stateful] #925

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdbefd1
Determine es build arguments in ci using unified job.
NickDris Nov 20, 2025
02180ec
Fix argument printing conditionals
NickDris Nov 20, 2025
de5dfdc
Fix prints
NickDris Nov 20, 2025
1c6c0c0
Fix typo
NickDris Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ jobs:
slack_channel: ${{ secrets.SLACK_CHANNEL }}
status: FAILED

determine-revision:
determine-es-build:
runs-on: ubuntu-22.04
outputs:
revision: ${{ steps.revision-argument.outputs.revision }}
release_build: ${{ steps.release-build-argument.outputs.release_build }}
steps:
- uses: actions/checkout@v4
- name: "Determine ES version"
Expand All @@ -53,6 +54,20 @@ jobs:
id: revision-argument
run: |
echo "revision= --revision=${{ steps.es-version.outputs.version }}" >> $GITHUB_OUTPUT
- name: "Determine ES release or snapshot"
id: release-build-argument
run: |
if [[ "${{ steps.es-version.outputs.version }}" != "current" && "${{ steps.es-version.outputs.version }}" != "latest" ]]; then
echo "release_build=" >> $GITHUB_ENV
else
echo "release_build= --source-build-release" >> $GITHUB_ENV
fi
- name: "Show revision argument"
if: ${{ steps.revision-argument.outputs.revision != '' }}
run: echo "Using${{ steps.revision-argument.outputs.revision }}"
- name: "Show release build argument"
if: ${{ steps.release-build-argument.outputs.release_build != '' }}
run: echo "Using${{ steps.release-build-argument.outputs.release_build }}"

filter-pr-changes:
runs-on: ubuntu-22.04
Expand All @@ -77,10 +92,13 @@ jobs:
| join(",")
')
if echo "$TRACKS" | grep -qw "full_ci"; then
echo 'track_filter=' >> $GITHUB_OUTPUT
echo 'track_filter=' >> $GITHUB_OUTPUT
else
echo "track_filter= --track-filter=$TRACKS" >> $GITHUB_OUTPUT
echo "track_filter= --track-filter=$TRACKS" >> $GITHUB_OUTPUT
fi
- name: show track filter argument
if: ${{ steps.track-filter.outputs.track_filter != '' }}
run: echo "Using${{ steps.track-filter.outputs.track_filter }}"

test:
strategy:
Expand Down Expand Up @@ -114,7 +132,7 @@ jobs:
rally-tracks-compat:
needs:
- filter-pr-changes
- determine-revision
- determine-es-build

strategy:
fail-fast: false
Expand Down Expand Up @@ -155,8 +173,8 @@ jobs:
run: df -h
- name: "Install dependencies"
run: python -m pip install .[develop]
- name: "Run tests${{ needs.filter-pr-changes.outputs.track_filter }}${{ needs.determine-revision.outputs.revision }}"
run: hatch -v -e it run test${{ needs.filter-pr-changes.outputs.track_filter }}${{ needs.determine-revision.outputs.revision }}
- name: "Run tests${{ needs.filter-pr-changes.outputs.track_filter }}${{ needs.determine-es-build.outputs.revision }}${{ needs.determine-es-build.outputs.release_build }}"
run: hatch -v -e it run test${{ needs.filter-pr-changes.outputs.track_filter }}${{ needs.determine-es-build.outputs.revision }}${{ needs.determine-es-build.outputs.release_build }}
timeout-minutes: 160
env:
# elastic/endpoint fetches assets from GitHub, authenticate to avoid
Expand Down
Loading