Skip to content

Pass request-timeout in SO Vector knn-recall-param-source#832

Merged
gbanasiak merged 3 commits intoelastic:masterfrom
gbanasiak:fix-so-vector-request-timeout
Aug 14, 2025
Merged

Pass request-timeout in SO Vector knn-recall-param-source#832
gbanasiak merged 3 commits intoelastic:masterfrom
gbanasiak:fix-so-vector-request-timeout

Conversation

@gbanasiak
Copy link
Contributor

This fixes #800 modification by passing request-timeout through custom param source.

It also switches to Elasticsearch.options() while setting request timeout, instead of passing it to relevant API methods, which produces shorter code and is recommended by Python ES client now.

@gbanasiak gbanasiak requested a review from benwtrent August 14, 2025 13:44
@gbanasiak gbanasiak enabled auto-merge (squash) August 14, 2025 13:59
@gbanasiak gbanasiak merged commit 8deaed5 into elastic:master Aug 14, 2025
13 checks passed
@gbanasiak gbanasiak deleted the fix-so-vector-request-timeout branch August 14, 2025 15:38
@esbenchmachine esbenchmachine added the backport pending Awaiting backport to stable release branch label Dec 19, 2025
@esbenchmachine
Copy link
Collaborator

@gbanasiak
A backport is pending for this PR. Please add all required vX.Y version labels.

  • If it is intended for the current Elasticsearch release version, apply the corresponding version label.
  • If it also supports past released versions, add those labels too.
  • If it only targets a future version, wait until that version label exists and then add it.
    (Each rally-tracks version label is created during the feature freeze of a new Elasticsearch branch).

Backporting entails:

  1. Ensure the correct version labels exist in this PR.
  2. Ensure backport PRs have backport label and are passing tests.
  3. Merge backport PRs (you can approve yourself and enable auto-merge).
  4. Remove backport pending label from this PR once all backport PRs are merged.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport pending Awaiting backport to stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments