Pass request-timeout in SO Vector knn-recall-param-source#832
Merged
gbanasiak merged 3 commits intoelastic:masterfrom Aug 14, 2025
Merged
Pass request-timeout in SO Vector knn-recall-param-source#832gbanasiak merged 3 commits intoelastic:masterfrom
gbanasiak merged 3 commits intoelastic:masterfrom
Conversation
benwtrent
approved these changes
Aug 14, 2025
Collaborator
|
@gbanasiak
Backporting entails:
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #800 modification by passing
request-timeoutthrough custom param source.It also switches to
Elasticsearch.options()while setting request timeout, instead of passing it to relevant API methods, which produces shorter code and is recommended by Python ES client now.