[elastic/shared] Remove system managed template fields#829
Merged
inqueue merged 1 commit intoelastic:masterfrom Jul 29, 2025
Merged
[elastic/shared] Remove system managed template fields#829inqueue merged 1 commit intoelastic:masterfrom
inqueue merged 1 commit intoelastic:masterfrom
Conversation
szybia
approved these changes
Jul 29, 2025
Comment on lines
+29
to
+30
| original.pop("created_date_millis", None) | ||
| original.pop("modified_date_millis", None) |
There was a problem hiding this comment.
just for transparency, doubt a problem, but we can also return {created,modified}_date which is human-readable, which is only returned if we supply the ?human=true HTTP param
but doubt that's an issue here...
Member
Author
There was a problem hiding this comment.
It isn't an issue here, but that would be a nice to have for the API.
inqueue
added a commit
to inqueue/rally-tracks
that referenced
this pull request
Aug 19, 2025
esbenchmachine
added
the
backport pending
Collaborator
|
@inqueue
Backporting entails:
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove system fields when updating templates.
Closes #828