Skip to content

Fix oversample params for knn tracks#814

Merged
benwtrent merged 1 commit intoelastic:masterfrom
benwtrent:feature/fix-knn-oversample-params-for-tracks
Jul 11, 2025
Merged

Fix oversample params for knn tracks#814
benwtrent merged 1 commit intoelastic:masterfrom
benwtrent:feature/fix-knn-oversample-params-for-tracks

Conversation

@benwtrent
Copy link
Member

oversample: 0 is a valid parameter value, it indicates no oversampling and overwrites any default oversampling applied at the index level.

This fixes msmarco-v2-vector and openai_vector to allow skipping oversampling

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 24c4b0b into elastic:master Jul 11, 2025
13 checks passed
@benwtrent benwtrent deleted the feature/fix-knn-oversample-params-for-tracks branch July 11, 2025 16:38
@esbenchmachine esbenchmachine added the backport pending Awaiting backport to stable release branch label Dec 19, 2025
@esbenchmachine
Copy link
Collaborator

@benwtrent
A backport is pending for this PR. Please add all required vX.Y version labels.

  • If it is intended for the current Elasticsearch release version, apply the corresponding version label.
  • If it also supports past released versions, add those labels too.
  • If it only targets a future version, wait until that version label exists and then add it.
    (Each rally-tracks version label is created during the feature freeze of a new Elasticsearch branch).

Backporting entails:

  1. Ensure the correct version labels exist in this PR.
  2. Ensure backport PRs have backport label and are passing tests.
  3. Merge backport PRs (you can approve yourself and enable auto-merge).
  4. Remove backport pending label from this PR once all backport PRs are merged.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport pending Awaiting backport to stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments