Remove fixed refresh interval from k8s-logging template#781
Merged
martijnvg merged 1 commit intoelastic:masterfrom Jun 5, 2025
Merged
Remove fixed refresh interval from k8s-logging template#781martijnvg merged 1 commit intoelastic:masterfrom
martijnvg merged 1 commit intoelastic:masterfrom
Conversation
…on logs unless the refresh_interval is specified (elastic#766)" This reverts commit 2b89a01.
inqueue
approved these changes
Jun 4, 2025
Member
inqueue
left a comment
inqueue
left a comment
There was a problem hiding this comment.
would this be ok for nightly env? iirc the issue that benchmark didn't complete in time was fixed, by introducing elastic-logs-logsdb-just-basic config.
Sounds good. LGTM
Member
Author
|
Thanks Jason! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is hiding a performance issue, that we're going to investigate (again).
@inqueue would this be ok for nightly env? iirc the issue that benchmark didn't complete in time was fixed, by introducing
elastic-logs-logsdb-just-basicconfig.Revert "Partial revert of 9fae039: use a 5s refresh for k8s application logs unless the refresh_interval is specified (#766)"
This reverts commit 2b89a01.
Relates to #2463