Skip to content

Support target ingest throughput options to wikipedia scaling challenges#776

Merged
kostasb merged 2 commits intomasterfrom
kostasb/add-target-throughput-wikipedia
May 6, 2025
Merged

Support target ingest throughput options to wikipedia scaling challenges#776
kostasb merged 2 commits intomasterfrom
kostasb/add-target-throughput-wikipedia

Conversation

@kostasb
Copy link

@kostasb kostasb commented May 5, 2025

Adds optional target ingestion throughput parameters to the ingest-autoscale and ingest-search-autoscale challenges.

@kostasb kostasb requested review from jimczi and lhearachel May 5, 2025 16:43
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kostasb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use as_ingest_target_throughputs to make it consistent with as_search_target_throughputs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed:
as_target_throughputs to as_ingest_target_throughputs
p_as_target_throughputs to p_as_ingest_target_throughputs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add that the document per second will be ingest_bulk_size * as_target_throughputs ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, added a relevant note to each challenge section.

@kostasb kostasb requested a review from jimczi May 6, 2025 09:06
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kostasb kostasb merged commit 354f5eb into master May 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments