Additional track changes for ES|QL full text functions#772
Merged
carlosdelest merged 22 commits intoelastic:masterfrom Jun 2, 2025
Merged
Additional track changes for ES|QL full text functions#772carlosdelest merged 22 commits intoelastic:masterfrom
carlosdelest merged 22 commits intoelastic:masterfrom
Conversation
# Conflicts: # elastic/logs/challenges/logging-querying-esql.json # elastic/logs/operations/esql-full-text-search.json # wikipedia/operations/default.json # wikipedia/track.py
Member
Author
jimczi
reviewed
Jun 2, 2025
wikipedia/track.py
Outdated
|
|
||
| return { | ||
| "body": { | ||
| "_source": {"includes": ["title"]}, |
Contributor
There was a problem hiding this comment.
We're not really testing source filtering here so should be removed?
Contributor
There was a problem hiding this comment.
I also wonder if we should remove the KEEP title, _score in the ES|QL query. If we want to test source filtering, it should be done in an explicit operation.
Member
Author
There was a problem hiding this comment.
I was trying to focus on the search performance and not on the source fetching differences between _search and ESQL - but I guess you're right. I will remove the source filtering.
ioanatia
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some additional changes:
elastic/logs track:
wikipedia track: