Skip to content

Fix ignore parameters in dbpedia and msmarco-passage-ranking #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimczi merged 3 commits into from
Mar 21, 2025
Merged

Fix ignore parameters in dbpedia and msmarco-passage-ranking #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e915c2b
Fix ignore parameters in dbpedia and msmarco-passage-ranking
jimczi Mar 20, 2025
516e845
address review comment
jimczi Mar 20, 2025
d8e51ee
fix type
jimczi Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions msmarco-passage-ranking/track.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,11 @@ def params(self):
raise Exception(f"The query strategy \\`{self._query_strategy}]\\` is not implemented")

self._iters = (self._iters + 1) % len(self._queries)
query["track_total_hits"] = self._track_total_hits
query["size"] = self._size
return {
"index": self._index_name,
"cache": self._cache,
"size": self._size,
"track_total_hits": self._track_total_hits,
"body": query,
}

Expand Down
4 changes: 2 additions & 2 deletions search/mteb/dbpedia/track.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,13 @@ def partition(self, partition_index, total_partitions):
def params(self):
query_obj = self._queries[self._iters]
query = generate_query(query_obj["text"], self._title_field, self._title_boost, self._text_field, self._text_boost)
query["track_total_hits"] = self._track_total_hits
query["size"] = self._size

self._iters = (self._iters + 1) % len(self._queries)
return {
"index": self._index_name,
"cache": self._cache,
"size": self._size,
"track_total_hits": self._track_total_hits,
"body": query,
}

Expand Down
Loading